Page MenuHomePhabricator

Don't retry queries on connections holding global locks
ClosedPublic

Authored by epriestley on Apr 24 2016, 3:33 PM.
Tags
None
Referenced Files
F19143946: D15789.diff
Wed, Dec 10, 2:37 PM
F19050091: D15789.id38049.diff
Thu, Nov 27, 7:13 PM
F19035785: D15789.id.diff
Tue, Nov 25, 6:10 PM
F19026532: D15789.diff
Mon, Nov 24, 11:20 AM
F18982471: D15789.id38036.diff
Nov 17 2025, 6:52 AM
F18902276: D15789.id.diff
Nov 8 2025, 12:31 AM
F18897419: D15789.id38049.diff
Nov 7 2025, 5:19 PM
F18873107: D15789.diff
Nov 5 2025, 7:59 AM
Subscribers
None

Details

Summary

Ref T10860. Currently, if we lose a connection that is holding a MySQL global lock, we may retry the query automatically.

Instead, we should abort, just like we do if we were in the middle of a transaction. Otherwise, code may still think it has the lock and do unsafe things.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Branch
lock-count
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11910
Build 14964: Run Core Tests
Build 14963: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't retry queries on connections holding global locks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 24 2016, 4:09 PM
This revision was automatically updated to reflect the committed changes.