Page MenuHomePhabricator

Parse Tags in commits message for revisions
ClosedPublic

Authored by avivey on Apr 19 2016, 11:04 PM.
Tags
None
Referenced Files
F13193514: D15762.id37980.diff
Sun, May 12, 2:18 PM
F13183679: D15762.id37979.diff
Fri, May 10, 11:01 AM
F13183318: D15762.id.diff
Fri, May 10, 8:20 AM
F13182445: D15762.diff
Thu, May 9, 11:29 PM
Unknown Object (File)
Mon, May 6, 2:08 AM
Unknown Object (File)
Sun, Apr 28, 11:25 AM
Unknown Object (File)
Fri, Apr 26, 5:11 PM
Unknown Object (File)
Wed, Apr 24, 11:52 PM
Subscribers

Details

Summary

This will stop breaking if you have subscribers and tags when updating a revision (Error parsing field "Subscribers": The objects you have listed include objects which do not exist (Tags:)), which I broke in D15749.

Test Plan

run through arc-diff --update that failed earlier.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to Parse Tags in commits message for revisions.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, chad.
avivey edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2016, 1:19 AM
This revision was automatically updated to reflect the committed changes.