Paths

Table of Contentst

Parse Tags in commits message for revisions
ClosedPublic
Actions

Authored by avivey on Apr 19 2016, 11:04 PM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

rP1344dda75692: Parse Tags in commits message for revisions

Summary

This will stop breaking if you have subscribers and tags when updating a revision (Error parsing field "Subscribers": The objects you have listed include objects which do not exist (Tags:)), which I broke in D15749.

Test Plan

run through arc-diff --update that failed earlier.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11850
Build 14873: Run Core Tests
Build 14872: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 37979.Apr 19 2016, 11:04 PM

avivey retitled this revision from to Parse Tags in commits message for revisions.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added reviewers: epriestley, chad.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 19 2016, 11:04 PM

Herald added a subscriber: Korvin. · View Herald Transcript

avivey updated this object.Apr 19 2016, 11:04 PM

avivey edited edge metadata.

epriestley accepted this revision.Apr 20 2016, 1:19 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2016, 1:19 AM

Closed by commit rP1344dda75692: Parse Tags in commits message for revisions (authored by avivey, committed by avivey). · Explain WhyApr 20 2016, 1:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialProjectsField.php

1 line

Diff 37979

View Options

src/applications/differential/customfield/DifferentialProjectsField.php

Parse Tags in commits message for revisionsClosedPublicActions