Page MenuHomePhabricator

Share Env/CWD methods between Passthru + ExecFuture, expose Env
ClosedPublic

Authored by epriestley on Apr 18 2016, 11:24 PM.
Tags
None
Referenced Files
F15008315: D15751.diff
Sun, Feb 16, 6:13 PM
F14961877: D15751.diff
Sun, Feb 16, 6:42 AM
Unknown Object (File)
Sun, Feb 9, 1:21 AM
Unknown Object (File)
Sun, Feb 9, 1:21 AM
Unknown Object (File)
Sun, Feb 9, 1:21 AM
Unknown Object (File)
Tue, Jan 28, 1:18 AM
Unknown Object (File)
Sat, Jan 25, 4:44 AM
Unknown Object (File)
Fri, Jan 24, 1:20 PM
Subscribers
None

Details

Summary

Ref T10751. This is several layers deep: I want to unit test environmental configuration for git/svn/hg commands, but there's currently no way to read it.

It's also duplicated between Passthru and ExecFuture classes.

Extend them from one class doing CWD + Env stuff. Clean that stuff up a little. Add a getEnv() for reading so I can do unit tests.

Test Plan

Ran arc unit --everything, see next diff for unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
env1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11829
Build 14842: Run Core Tests
Build 14841: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Share Env/CWD methods between Passthru + ExecFuture, expose Env.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 2:29 AM
This revision was automatically updated to reflect the committed changes.