Page MenuHomePhabricator

Share Env/CWD methods between Passthru + ExecFuture, expose Env
ClosedPublic

Authored by epriestley on Apr 18 2016, 11:24 PM.
Tags
None
Referenced Files
F15390453: D15751.id.diff
Sat, Mar 15, 6:13 AM
F15387322: D15751.diff
Sat, Mar 15, 2:12 AM
F15381280: D15751.id37956.diff
Fri, Mar 14, 6:51 AM
Unknown Object (File)
Mon, Feb 24, 12:37 PM
Unknown Object (File)
Mon, Feb 24, 7:30 AM
Unknown Object (File)
Feb 18 2025, 5:09 AM
Unknown Object (File)
Feb 16 2025, 6:13 PM
Unknown Object (File)
Feb 16 2025, 6:42 AM
Subscribers
None

Details

Summary

Ref T10751. This is several layers deep: I want to unit test environmental configuration for git/svn/hg commands, but there's currently no way to read it.

It's also duplicated between Passthru and ExecFuture classes.

Extend them from one class doing CWD + Env stuff. Clean that stuff up a little. Add a getEnv() for reading so I can do unit tests.

Test Plan

Ran arc unit --everything, see next diff for unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
env1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11829
Build 14842: Run Core Tests
Build 14841: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Share Env/CWD methods between Passthru + ExecFuture, expose Env.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 2:29 AM
This revision was automatically updated to reflect the committed changes.