Page MenuHomePhabricator

Share Env/CWD methods between Passthru + ExecFuture, expose Env
ClosedPublic

Authored by epriestley on Apr 18 2016, 11:24 PM.
Tags
None
Referenced Files
F18783624: D15751.id37956.diff
Mon, Oct 13, 8:31 AM
F18750838: D15751.id37960.diff
Sat, Oct 4, 9:02 AM
F18678553: D15751.diff
Thu, Sep 25, 10:48 PM
F18678198: D15751.id.diff
Thu, Sep 25, 10:26 PM
F18620793: D15751.diff
Sep 15 2025, 6:20 AM
F18362536: D15751.id37956.diff
Aug 27 2025, 2:15 PM
F18218832: D15751.id.diff
Aug 19 2025, 10:37 AM
F18208859: D15751.diff
Aug 18 2025, 9:58 PM
Subscribers
None

Details

Summary

Ref T10751. This is several layers deep: I want to unit test environmental configuration for git/svn/hg commands, but there's currently no way to read it.

It's also duplicated between Passthru and ExecFuture classes.

Extend them from one class doing CWD + Env stuff. Clean that stuff up a little. Add a getEnv() for reading so I can do unit tests.

Test Plan

Ran arc unit --everything, see next diff for unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Share Env/CWD methods between Passthru + ExecFuture, expose Env.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 2:29 AM
This revision was automatically updated to reflect the committed changes.