Page MenuHomePhabricator

Share Env/CWD methods between Passthru + ExecFuture, expose Env
ClosedPublic

Authored by epriestley on Apr 18 2016, 11:24 PM.
Tags
None
Referenced Files
F19148705: D15751.id37956.diff
Dec 10 2025, 6:39 PM
F19143518: D15751.id37956.diff
Dec 10 2025, 2:16 PM
F19000144: D15751.diff
Nov 20 2025, 10:59 PM
F18998848: D15751.diff
Nov 20 2025, 7:35 PM
F18874919: D15751.diff
Nov 5 2025, 4:17 PM
F18821419: D15751.id37960.diff
Oct 22 2025, 10:59 PM
F18820064: D15751.id37956.diff
Oct 22 2025, 12:22 PM
F18783624: D15751.id37956.diff
Oct 13 2025, 8:31 AM
Subscribers
None

Details

Summary

Ref T10751. This is several layers deep: I want to unit test environmental configuration for git/svn/hg commands, but there's currently no way to read it.

It's also duplicated between Passthru and ExecFuture classes.

Extend them from one class doing CWD + Env stuff. Clean that stuff up a little. Add a getEnv() for reading so I can do unit tests.

Test Plan

Ran arc unit --everything, see next diff for unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Share Env/CWD methods between Passthru + ExecFuture, expose Env.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 2:29 AM
This revision was automatically updated to reflect the committed changes.