Page MenuHomePhabricator

Share Env/CWD methods between Passthru + ExecFuture, expose Env
ClosedPublic

Authored by epriestley on Apr 18 2016, 11:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 13, 12:52 PM
Unknown Object (File)
Thu, Aug 11, 3:11 PM
Unknown Object (File)
Mon, Aug 8, 11:20 PM
Unknown Object (File)
Mon, Aug 8, 11:19 PM
Unknown Object (File)
Sat, Aug 6, 10:55 PM
Unknown Object (File)
Sun, Jul 31, 1:37 AM
Unknown Object (File)
Wed, Jul 20, 7:07 AM
Unknown Object (File)
Jul 9 2022, 10:55 AM
Subscribers
None

Details

Summary

Ref T10751. This is several layers deep: I want to unit test environmental configuration for git/svn/hg commands, but there's currently no way to read it.

It's also duplicated between Passthru and ExecFuture classes.

Extend them from one class doing CWD + Env stuff. Clean that stuff up a little. Add a getEnv() for reading so I can do unit tests.

Test Plan

Ran arc unit --everything, see next diff for unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Share Env/CWD methods between Passthru + ExecFuture, expose Env.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 2:29 AM
This revision was automatically updated to reflect the committed changes.