Page MenuHomePhabricator

Share Env/CWD methods between Passthru + ExecFuture, expose Env
ClosedPublic

Authored by epriestley on Apr 18 2016, 11:24 PM.
Tags
None
Referenced Files
F14017714: D15751.id37960.diff
Mon, Nov 4, 9:40 PM
F14010777: D15751.diff
Thu, Oct 31, 12:12 PM
F13994247: D15751.diff
Wed, Oct 23, 4:53 AM
F13989165: D15751.diff
Mon, Oct 21, 6:33 PM
F13988072: D15751.diff
Mon, Oct 21, 12:59 PM
F13970052: D15751.diff
Thu, Oct 17, 5:24 AM
F13965560: D15751.diff
Wed, Oct 16, 2:50 AM
F13965457: D15751.id.diff
Wed, Oct 16, 2:16 AM
Subscribers
None

Details

Summary

Ref T10751. This is several layers deep: I want to unit test environmental configuration for git/svn/hg commands, but there's currently no way to read it.

It's also duplicated between Passthru and ExecFuture classes.

Extend them from one class doing CWD + Env stuff. Clean that stuff up a little. Add a getEnv() for reading so I can do unit tests.

Test Plan

Ran arc unit --everything, see next diff for unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Share Env/CWD methods between Passthru + ExecFuture, expose Env.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 2:29 AM
This revision was automatically updated to reflect the committed changes.