Page MenuHomePhabricator

Improve performance of `arc branch` in Git with many branches
ClosedPublic

Authored by epriestley on Apr 16 2016, 4:43 PM.
Tags
None
Referenced Files
F15407493: D15735.diff
Tue, Mar 18, 5:50 PM
Unknown Object (File)
Mon, Feb 24, 5:11 AM
Unknown Object (File)
Feb 11 2025, 1:01 PM
Unknown Object (File)
Feb 10 2025, 12:54 PM
Unknown Object (File)
Feb 9 2025, 1:19 AM
Unknown Object (File)
Feb 1 2025, 5:38 AM
Unknown Object (File)
Jan 24 2025, 1:15 PM
Unknown Object (File)
Jan 24 2025, 6:46 AM
Subscribers
None

Details

Summary

This is mostly just a personal quality-of-life fix. I run this command fairly often and having it return a little faster is nice.

This replaces a git show for each individual branch with a big git for-each-ref which we were already running anyway. This is quite a bit faster.

This command also occasionally hangs or segfaults for me while executing the huge pile of subprocesses. This is unreliable to reproduce, probably some bug in some PHP extension I have, and likely hard to narrow down, and this approach is better in every way anyway.

Test Plan
  • Ran arc branch in Git, observed faster output (in my phabricator/, about 2000ms -> 1200ms).
  • Ran arc feature in Mercurial.

Diff Detail

Repository
rARC Arcanist
Branch
branch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11789
Build 14782: Run Core Tests
Build 14781: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve performance of `arc branch` in Git with many branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.