Page MenuHomePhabricator

Improve performance of `arc branch` in Git with many branches
ClosedPublic

Authored by epriestley on Apr 16 2016, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 11, 1:01 PM
Unknown Object (File)
Mon, Feb 10, 12:54 PM
Unknown Object (File)
Sun, Feb 9, 1:19 AM
Unknown Object (File)
Sat, Feb 1, 5:38 AM
Unknown Object (File)
Fri, Jan 24, 1:15 PM
Unknown Object (File)
Fri, Jan 24, 6:46 AM
Unknown Object (File)
Tue, Jan 21, 2:07 AM
Unknown Object (File)
Jan 17 2025, 11:24 PM
Subscribers
None

Details

Summary

This is mostly just a personal quality-of-life fix. I run this command fairly often and having it return a little faster is nice.

This replaces a git show for each individual branch with a big git for-each-ref which we were already running anyway. This is quite a bit faster.

This command also occasionally hangs or segfaults for me while executing the huge pile of subprocesses. This is unreliable to reproduce, probably some bug in some PHP extension I have, and likely hard to narrow down, and this approach is better in every way anyway.

Test Plan
  • Ran arc branch in Git, observed faster output (in my phabricator/, about 2000ms -> 1200ms).
  • Ran arc feature in Mercurial.

Diff Detail

Repository
rARC Arcanist
Branch
branch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11789
Build 14782: Run Core Tests
Build 14781: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve performance of `arc branch` in Git with many branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2016, 5:01 PM
This revision was automatically updated to reflect the committed changes.