1.
ClosedPublic
Actions

Authored by lpriestley on Apr 15 2016, 8:54 PM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9295: Date chooser picket fence issue with next month

Commits

rPeeccaf99b6cd: When scrolling forward a month in calendar date picker from 1/31, next chosen…

Summary

Fixes T9295

Test Plan

Create event, open datepicker for start date, choose 1/31/2016, open datepicker again, click right button to scroll month. New suggested date should be 2/29/2016

Diff Detail

Repository

rP Phabricator

Branch

datepickermonthjump

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11768
Build 14749: Run Core Tests
Build 14748: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	181 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 6 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (1 Failed · 314 Passed)

Event Timeline

lpriestley updated this revision to Diff 37898.Apr 15 2016, 8:54 PM

lpriestley retitled this revision from to When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added reviewers: epriestley, chad.

lpriestley added a task: T9295: Date chooser picket fence issue with next month.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2016, 8:54 PM

Herald added a subscriber: Korvin. · View Herald Transcript