Use monospaced font in Passphrase "Reveal Secret" dialog
ClosedPublic
Actions

Authored by epriestley on Apr 14 2016, 8:08 PM.

Details

Reviewers

yelirekim
chad

Maniphest Tasks

T10812: Use monospaced fonts when displaying credentials in passphrase

Commits

rP1b2b84ce1f3d: Use monospaced font in Passphrase "Reveal Secret" dialog

Summary

Fixes T10812. Make it easier to disambiguate great passwords like iI|l1oO()thenumber1nospellitout.

Test Plan

Screen Shot 2016-04-14 at 1.06.41 PM.png (519×796 px, 27 KB)

Diff Detail

Repository

rP Phabricator

Branch

passmono1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11732
Build 14698: Run Core Tests
Build 14697: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37863.Apr 14 2016, 8:08 PM

epriestley retitled this revision from to Use monospaced font in Passphrase "Reveal Secret" dialog.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, yelirekim.

epriestley added a task: T10812: Use monospaced fonts when displaying credentials in passphrase.

yelirekim accepted this revision.Apr 14 2016, 8:09 PM

yelirekim edited edge metadata.

This revision is now accepted and ready to land.Apr 14 2016, 8:09 PM

Closed by commit rP1b2b84ce1f3d: Use monospaced font in Passphrase "Reveal Secret" dialog (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 8:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

controller/

PassphraseCredentialRevealController.php

1 line

Diff 37863

View Options

src/applications/passphrase/controller/PassphraseCredentialRevealController.php

Use monospaced font in Passphrase "Reveal Secret" dialogClosedPublicActions