Page MenuHomePhabricator

When proxying the SVN protocol, don't mutate URIs in protocol frames if we're an intracluster proxy
ClosedPublic

Authored by epriestley on Apr 14 2016, 5:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:57 AM
Unknown Object (File)
Sun, Apr 21, 7:43 PM
Unknown Object (File)
Thu, Apr 11, 12:33 PM
Unknown Object (File)
Apr 2 2024, 2:02 AM
Unknown Object (File)
Mar 31 2024, 4:12 PM
Unknown Object (File)
Mar 5 2024, 6:12 PM
Unknown Object (File)
Mar 5 2024, 6:12 PM
Unknown Object (File)
Mar 5 2024, 4:47 PM
Subscribers
None

Details

Summary

Ref T10809. Currently, both the proxy and target may mutate URIs (rewriting "svn+ssh://x/diffusion/Y/" to a path on disk).

I believe this previously worked by fate/chance/luck since both URI variants contain the repository information, but the algorithms were tightened up recently with callsign removal.

Stop rewriting them if we're the intracluster proxy -- they only need to be rewritten on the target host.

Test Plan
  • Checked out a proxied SVN repository, with and without a callsign.
  • Checked out an unproxied SVN repository, with and without a callsign.

Diff Detail

Repository
rP Phabricator
Branch
svn1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11724
Build 14687: Run Core Tests
Build 14686: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When proxying the SVN protocol, don't mutate URIs in protocol frames if we're an intracluster proxy.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 5:14 PM
This revision was automatically updated to reflect the committed changes.