Page MenuHomePhabricator
Differential D15703

Complete modernization of Aphlict configuration
ClosedPublic
Actions

Authored by epriestley on Apr 13 2016, 9:29 PM.
Tags
None
Referenced Files
F13214108: D15703.diff
Fri, May 17, 8:38 AM
F13201364: D15703.diff
Tue, May 14, 11:19 AM
F13198032: D15703.id.diff
Mon, May 13, 2:57 AM
Unknown Object (File)
Tue, May 7, 10:06 AM
Unknown Object (File)
Fri, May 3, 10:09 AM
Unknown Object (File)
Thu, Apr 25, 4:01 PM
Unknown Object (File)
Fri, Apr 19, 4:28 PM
Unknown Object (File)
Fri, Apr 19, 10:38 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10697: Move Aphlict server configuration to a separate configuration file
Commits
rP2930733ac99f: Complete modernization of Aphlict configuration
Summary

Fixes T10697. This finishes bringing the rest of the config up to cluster power levels.

Phabricator is now given an arbitrarily long list of notification servers.

Each Aphlict server is given an arbitrarily long list of ports to run services on.

Users are free to make them meet in the middle by proxying whatever they want to whatever else they want.

This should also accommodate clustering fairly easily in the future.

Also rewrote the status UI and changed a million other things. 🐗

Test Plan

Screen Shot 2016-04-13 at 2.26.10 PM.png (913×1 px, 131 KB)

Screen Shot 2016-04-13 at 2.26.24 PM.png (1×1 px, 191 KB)

Diff Detail

Repository
rP Phabricator
Branch
aphlict5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/view/page/PhabricatorStandardPageView.php:542XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11701
Build 14655: Run Core Tests
Build 14654: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37833.Apr 13 2016, 9:29 PM
epriestley retitled this revision from to Complete modernization of Aphlict configuration.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10697: Move Aphlict server configuration to a separate configuration file.
chad accepted this revision.Apr 14 2016, 4:10 AM
chad edited edge metadata.
chad added inline comments.
src/docs/user/configuration/notifications.diviner
177

websocket?

support/aphlict/server/aphlict_server.js
85

cool story, bro

This revision is now accepted and ready to land.Apr 14 2016, 4:10 AM
Closed by commit rP2930733ac99f: Complete modernization of Aphlict configuration (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 11:57 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D15708: Fix a "websokket" typo.Apr 14 2016, 12:32 PM
epriestley mentioned this in rP383ae7621f95: Fix a "websokket" typo.Apr 14 2016, 5:41 PM
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 14 2016, 5:50 PM
epriestley mentioned this in Z1336: General Chat.Apr 26 2016, 11:19 PM

Revision Contents
Changeset List

Diff 37833

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/application/PhabricatorConfigApplication.php

Loading...
View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigController.php

Loading...
View Options

src/applications/config/option/PhabricatorNotificationConfigOptions.php

Loading...
View Options

src/applications/notification/application/PhabricatorNotificationsApplication.php

Loading...
View Options

src/applications/notification/client/PhabricatorNotificationClient.php

Loading...
View Options

src/applications/notification/client/PhabricatorNotificationServerRef.php

Loading...
View Options

src/applications/notification/config/PhabricatorNotificationServersConfigOptionType.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationStatusController.php

Loading...
View Options

src/applications/notification/setup/PhabricatorAphlictSetupCheck.php

Loading...
View Options

src/applications/settings/panel/PhabricatorDesktopNotificationsSettingsPanel.php

Loading...
View Options

src/docs/user/cluster/cluster_databases.diviner

Loading...
View Options

src/docs/user/configuration/notifications.diviner

Loading...
View Options

src/infrastructure/testing/PhabricatorTestCase.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

support/aphlict/server/aphlict_server.js

Loading...
View Options

support/aphlict/server/lib/AphlictAdminServer.js

Loading...
View Options

support/aphlict/server/lib/AphlictClientServer.js

Loading...
View Options

support/aphlict/server/lib/AphlictListener.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Leader.js

Loading...
Phabricator · Built by Phacility