Page MenuHomePhabricator
Differential D15648

Fix getInterestingMoves() fatal?
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 10:57 PM.
Tags
None
Referenced Files
F15463603: D15648.id37708.diff
Wed, Apr 2, 1:21 AM
F15452832: D15648.diff
Sat, Mar 29, 7:36 AM
F15450478: D15648.id.diff
Fri, Mar 28, 3:54 PM
F15421932: D15648.id.diff
Sat, Mar 22, 3:43 AM
F15420151: D15648.id37709.diff
Fri, Mar 21, 11:49 AM
F15376888: D15648.diff
Thu, Mar 13, 6:25 AM
F15336531: D15648.diff
Sat, Mar 8, 7:23 PM
Unknown Object (File)
Feb 16 2025, 6:37 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields
Commits
rP0650f725f1f0: Fix getInterestingMoves() fatal?
Summary

Fixes T10740. Probably?

Test Plan

No you

Diff Detail

Repository
rP Phabricator
Branch
xactionbleed
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11573
Build 14459: Run Core Tests
Build 14458: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37708.Apr 6 2016, 10:57 PM
epriestley retitled this revision from to Fix getInterestingMoves() fatal?.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields.
chad accepted this revision.Apr 6 2016, 11:00 PM
chad edited edge metadata.

Yep, no more fatals.

This revision is now accepted and ready to land.Apr 6 2016, 11:00 PM
epriestley added a comment.Apr 6 2016, 11:02 PM

Cool, thanks for catching this!

Closed by commit rP0650f725f1f0: Fix getInterestingMoves() fatal? (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 11:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
1 line

Diff 37708

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility