Differential D15648

Fix getInterestingMoves() fatal?
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 10:57 PM.

Details

Reviewers

chad

Maniphest Tasks

T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields

Commits

rP0650f725f1f0: Fix getInterestingMoves() fatal?

Summary

Fixes T10740. Probably?

Test Plan

No you

Diff Detail

Repository

rP Phabricator

Branch

xactionbleed

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11573
Build 14459: Run Core Tests
Build 14458: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37708.Apr 6 2016, 10:57 PM

epriestley retitled this revision from to Fix getInterestingMoves() fatal?.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields.

Yep, no more fatals.

This revision is now accepted and ready to land.Apr 6 2016, 11:00 PM

Cool, thanks for catching this!

Closed by commit rP0650f725f1f0: Fix getInterestingMoves() fatal? (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 11:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

1 line

Diff 37708

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Fix getInterestingMoves() fatal?ClosedPublicActions