Remove bogus '$this->resource' from SES error handling pathway
ClosedPublic
Actions

Authored by epriestley on Apr 5 2016, 8:18 PM.

Details

Reviewers

chad

Maniphest Tasks

T10728: No mail deliveries: Mail daemon throwing "Undefined property" exceptions in a loop

Commits

rPc29bbbab19e4: Remove bogus '$this->resource' from SES error handling pathway

Summary

Ref T10728. This property does not exist and is never referenced. The 'resource' key is also never referenced, so I believe this can be safely removed.

Test Plan

Will make @amckinley do my job for me.

Diff Detail

Repository

rP Phabricator

Branch

ses1

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 11518
Build 14379: Run Core Tests
Build 14378: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37651.Apr 5 2016, 8:18 PM

epriestley retitled this revision from to Remove bogus '$this->resource' from SES error handling pathway.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10728: No mail deliveries: Mail daemon throwing "Undefined property" exceptions in a loop.

epriestley added a subscriber: amckinley.

chad accepted this revision.Apr 5 2016, 8:18 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 5 2016, 8:18 PM

Closed by commit rPc29bbbab19e4: Remove bogus '$this->resource' from SES error handling pathway (authored by epriestley, committed by epriestley). · Explain WhyApr 5 2016, 8:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

externals/

amazon-ses/

ses.php

1 line

Diff 37651

View Options

externals/amazon-ses/ses.php

Remove bogus '$this->resource' from SES error handling pathwayClosedPublicActions