Page MenuHomePhabricator

Fix resolution of commits in SVN repositories without callsigns
ClosedPublic

Authored by epriestley on Apr 4 2016, 4:43 PM.
Tags
None
Referenced Files
F14737645: D15607.diff
Sun, Jan 19, 8:28 AM
Unknown Object (File)
Fri, Jan 10, 7:16 AM
Unknown Object (File)
Fri, Dec 27, 3:30 AM
Unknown Object (File)
Dec 17 2024, 8:55 AM
Unknown Object (File)
Dec 10 2024, 7:23 PM
Unknown Object (File)
Dec 6 2024, 9:38 PM
Unknown Object (File)
Dec 6 2024, 5:03 PM
Unknown Object (File)
Nov 30 2024, 11:48 AM
Subscribers
None

Details

Summary

Fixes T10721. When trying to load commits by identifier, we would take some bad pathways in Subversion if the repository had no callsign and end up missing the commits.

Fix this logic so it works for either callsigns (e.g., if passed rXyyy) or with PHIDs if passed repositories.

Test Plan
  • Viewed SVN commit in a Subversion repository with no callsign.
  • Added a callsign, looked at it again.
  • Viewed non-SVN commits in callsign and non-callsign repositories.

Diff Detail

Repository
rP Phabricator
Branch
svncallsign
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11483
Build 14325: Run Core Tests
Build 14324: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix resolution of commits in SVN repositories without callsigns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2016, 4:44 PM
This revision was automatically updated to reflect the committed changes.