Issuing the second query immediately seems generally reasonable to me.

There is a tiny chance that something like this could possibly happen, either now or in the future:

getBadgePHIDs() is cached, so it could return slightly out-of-date data, in theory. Even if it wasn't, there's a tiny but nonzero amount of time between the query powering getBadgePHIDs() and the query checking for the user's awards.

So getBadgePHIDs()could say the user has badges, but by the time the second query executes a millisecond later the user might not have any badges anymore (someone could have removed them).

Then we'd do a bogus query on no PHIDs, which would throw an exception.

This is probably impossible. If it isn't impossible, the window is so narrow that you probably couldn't hit it by trying. The badge cache on users may not even make sense soon, making it 100% impossible. Even if this is possible to hit, reloading the page would fix it. So waiting for this to actually present a problem seems fine to me.

For the clicking thing, I think we have to write custom JS. Currently, it's powered by a simple behavior (jx-toggle-class) in PHUIBadgeView, which just says "toggle this CSS class on/off when the thing is clicked".

There's no way to make this behavior more complex/subtle (e.g., ignore clicks on links) and it's important that it not ignore clicks on links in all cases because it also powers stuff like "Show/Hide Details" links elsewhere.

So this probably boils down to:

• Write a new behavior which does the toggling.
• It can mostly work like jx-toggle-class, but can probably be a bit simpler since it's custom.
• It should ignore clicks on links inside the card.

This seems fine to push to a future diff to me.

To check if something is a click on a link, you'll do something like this:

JX.Stratcom.listen('badge-view', 'click', function(e) {
  if (e.getNode('tag:a')) {
    // If the event has a `tag:a` node on it, that means the user
    // either clicked a link or some other node inside a link.
    return;
  }
  // ...
});