Differential D15529

Don't try to center dialogs horizontally
ClosedPublic
Actions

Authored by epriestley on Mar 26 2016, 7:26 PM.

Details

Reviewers

chad

Maniphest Tasks

T10302: Workflow.js is picking up 7px from somewhere

Commits

rPc286d2b441bd: Don't try to center dialogs horizontally

Summary

Fixes T10302. I think we had fixed-width dialog containers in the past (?) but they all handle their own centering now.

This was causing them to be slightly off-center as a result, and creating the 7px issue in T10302.

Test Plan

Viewed a wide dialog (task edit).
Viewed a narrow dialog (notification dismissal confirmation).
Viewed dialogs on wide/narrow screens.

Diff Detail

Repository

rP Phabricator

Branch

dcenter

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11299
Build 14050: Run Core Tests
Build 14049: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37435.Mar 26 2016, 7:26 PM

epriestley retitled this revision from to Don't try to center dialogs horizontally.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10302: Workflow.js is picking up 7px from somewhere.

Herald edited edge metadata. · View Herald TranscriptMar 26 2016, 7:26 PM

chad accepted this revision.Mar 26 2016, 7:28 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 26 2016, 7:28 PM

Closed by commit rPc286d2b441bd: Don't try to center dialogs horizontally (authored by epriestley, committed by epriestley). · Explain WhyMar 26 2016, 7:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

28 lines

webroot/

rsrc/

externals/

javelin/

lib/

Workflow.js

2 lines

Diff 37435

View Options

resources/celerity/map.php