Page MenuHomePhabricator
Differential D15528

Fix Diffusion blame columns when disabling blame
ClosedPublic
Actions

Authored by epriestley on Mar 26 2016, 6:58 PM.
Tags
None
Referenced Files
F14064273: D15528.diff
Mon, Nov 18, 10:43 PM
F14052984: D15528.diff
Fri, Nov 15, 11:53 AM
F14040799: D15528.diff
Mon, Nov 11, 1:33 PM
F14025008: D15528.diff
Thu, Nov 7, 1:55 PM
F13999749: D15528.diff
Thu, Oct 24, 4:59 PM
F13965225: D15528.diff
Oct 16 2024, 12:43 AM
Unknown Object (File)
Oct 1 2024, 7:13 PM
Unknown Object (File)
Sep 18 2024, 1:22 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10385: Diffusion code view doesn't hide blame pane
Commits
rP060f96079def: Fix Diffusion blame columns when disabling blame
Summary

Fixes T10385. Two issues:

  • $show_blame and $show_color were improperly swapped.
  • Code to hide these columns got dropped somewhere, probably in my recent-ish rewrite.
Test Plan
  • Showed/hid blame.
  • Showed/hid colors.

Diff Detail

Repository
rP Phabricator
Branch
blamecol1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11296
Build 14046: Run Core Tests
Build 14045: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37432.Mar 26 2016, 6:58 PM
epriestley retitled this revision from to Fix Diffusion blame columns when disabling blame.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10385: Diffusion code view doesn't hide blame pane.
Herald edited edge metadata. · View Herald TranscriptMar 26 2016, 6:58 PM
chad accepted this revision.Mar 26 2016, 7:00 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 26 2016, 7:00 PM
chad added a comment.Mar 26 2016, 7:01 PM

I tried to fix it during the re-write, the bug was around before then. I don't think it was me?

chad added a comment.Mar 26 2016, 7:01 PM

oh, in your re-write. yes, yes, it was you. i never write bugs.

epriestley added a comment.Mar 26 2016, 7:02 PM

No, definitely not you -- me in earlier rewrites related to callsigns, I think.

epriestley added a comment.Mar 26 2016, 7:02 PM

:3

Closed by commit rP060f96079def: Fix Diffusion blame columns when disabling blame (authored by epriestley, committed by epriestley). · Explain WhyMar 26 2016, 7:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
42 lines

Diff 37432

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility