Page MenuHomePhabricator
Differential D15525

Fix unit test view detail fatal
ClosedPublic
Actions

Authored by epriestley on Mar 25 2016, 10:46 PM.
Tags
None
Referenced Files
F13295163: D15525.diff
Wed, Jun 5, 11:10 PM
F13242540: D15525.diff
Thu, May 23, 2:51 AM
F13236569: D15525.id37427.diff
Tue, May 21, 10:10 AM
F13227004: D15525.id37428.diff
Mon, May 20, 12:40 AM
F13220851: D15525.diff
Sun, May 19, 1:59 AM
F13203255: D15525.diff
Tue, May 14, 11:36 PM
F13185549: D15525.diff
Sat, May 11, 3:00 AM
Unknown Object (File)
May 7 2024, 5:29 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10674: Latest HEAD broke viewing unit test results in Harbormaster
Commits
rP39a4d5b8c1bb: Fix unit test view detail fatal
Summary

Fixes T10674.

Test Plan

Screen Shot 2016-03-25 at 3.45.33 PM.png (1×1 px, 295 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11290
Build 14037: Run Core Tests
Build 14036: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37427.Mar 25 2016, 10:46 PM
epriestley retitled this revision from to Fix unit test view detail fatal.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10674: Latest HEAD broke viewing unit test results in Harbormaster.
Herald edited edge metadata. · View Herald TranscriptMar 25 2016, 10:46 PM
epriestley added a comment.Mar 25 2016, 10:47 PM

(Or counter-diff me, not sure if you have a reasonable test case for this locally.)

chad accepted this revision.Mar 25 2016, 10:48 PM
chad edited edge metadata.
chad added inline comments.
src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php
45

should setBackground here, unless it looks terrible.

This revision is now accepted and ready to land.Mar 25 2016, 10:48 PM
Closed by commit rP39a4d5b8c1bb: Fix unit test view detail fatal (authored by epriestley, committed by epriestley). · Explain WhyMar 25 2016, 10:49 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Mar 25 2016, 10:51 PM

whoops sry

epriestley mentioned this in D15526: Set blue background (unless it looks terrible).Mar 25 2016, 10:55 PM
epriestley mentioned this in rPd784d9c0440c: Set blue background (unless it looks terrible).Mar 25 2016, 10:58 PM

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
4 lines

Diff 37427

View Options

src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php

Loading...
Phabricator · Built by Phacility