Page MenuHomePhabricator
Differential D15484

Use AphrontRequestStream to read request input
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 6:06 PM.
Tags
None
Referenced Files
F15592052: D15484.diff
Sat, May 10, 3:48 AM
F15548149: D15484.diff
Sat, Apr 26, 10:09 PM
F15505146: D15484.diff
Tue, Apr 15, 12:06 AM
F15487503: D15484.id37317.diff
Thu, Apr 10, 2:40 PM
F15486116: D15484.id37331.diff
Apr 10 2025, 5:10 AM
F15484741: D15484.id37317.diff
Apr 9 2025, 7:50 PM
F15480126: D15484.id.diff
Apr 8 2025, 11:58 AM
F15477520: D15484.diff
Apr 7 2025, 3:41 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10604: Allow application code to stream request data
Commits
Restricted Diffusion Commit
rP2b02024e2329: Use AphrontRequestStream to read request input
Summary

Ref T10604. This uses the new standalone stream reader introduced in D15483 to read request data, instead of putting the logic in PhabricatorStartup.

It also doesn't read request data until it specifically needs to. This supports, e.g., streaming Git LFS PUT requests, and streaming more types of requests in the future.

Test Plan

See D15483. Made various different types of requests and wasn't immediately able to break anything.

Diff Detail

Repository
rP Phabricator
Branch
lfs8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11177
Build 13864: Run Core Tests
Build 13863: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37317.Mar 16 2016, 6:06 PM
epriestley retitled this revision from to Use AphrontRequestStream to read request input.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10604: Allow application code to stream request data.
Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 6:06 PM
chad accepted this revision.Mar 16 2016, 6:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 6:07 PM
Closed by commit rP2b02024e2329: Use AphrontRequestStream to read request input (authored by epriestley, committed by epriestley). · Explain WhyMar 17 2016, 3:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
configuration/
17 lines
support/
61 lines

Diff 37317

View Options

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

Loading...
View Options

support/PhabricatorStartup.php

Loading...
Phabricator · Built by Phacility