Page MenuHomePhabricator

Use AphrontRequestStream to read request input
ClosedPublic

Authored by epriestley on Mar 16 2016, 6:06 PM.
Tags
None
Referenced Files
F15274808: D15484.diff
Sat, Mar 1, 1:13 PM
Unknown Object (File)
Sun, Feb 16, 6:32 AM
Unknown Object (File)
Mon, Feb 10, 7:24 PM
Unknown Object (File)
Sun, Feb 9, 1:02 AM
Unknown Object (File)
Sun, Feb 9, 1:02 AM
Unknown Object (File)
Mon, Feb 3, 3:19 PM
Unknown Object (File)
Fri, Jan 31, 2:29 AM
Unknown Object (File)
Fri, Jan 31, 2:17 AM
Subscribers
None

Details

Summary

Ref T10604. This uses the new standalone stream reader introduced in D15483 to read request data, instead of putting the logic in PhabricatorStartup.

It also doesn't read request data until it specifically needs to. This supports, e.g., streaming Git LFS PUT requests, and streaming more types of requests in the future.

Test Plan

See D15483. Made various different types of requests and wasn't immediately able to break anything.

Diff Detail

Repository
rP Phabricator
Branch
lfs8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11177
Build 13864: Run Core Tests
Build 13863: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use AphrontRequestStream to read request input.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 6:07 PM
This revision was automatically updated to reflect the committed changes.