Page MenuHomePhabricator

When replying to a ghost comment, attach the reply to the same place
ClosedPublic

Authored by epriestley on Mar 11 2016, 12:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 7:00 AM
Unknown Object (File)
Fri, Dec 20, 8:53 PM
Unknown Object (File)
Fri, Dec 20, 7:37 AM
Unknown Object (File)
Dec 13 2024, 2:07 AM
Unknown Object (File)
Dec 12 2024, 10:33 PM
Unknown Object (File)
Dec 10 2024, 1:18 PM
Unknown Object (File)
Dec 4 2024, 6:24 AM
Unknown Object (File)
Nov 30 2024, 3:31 AM
Subscribers

Details

Summary

Fixes T10562. I left this behavior sort of ambiguous in the original implementation because I didn't anticipate or stumble across this situation.

It's easy to fix: when you reply to a ghost, just put the reply in the exact same place as the ghost (even if it's a different diff), so they always move/ghost/port/thread together.

Test Plan

See T10562 for reproduction steps and a "before" picture. Here's the after picture:

Screen Shot 2016-03-10 at 4.04.52 PM.png (922×924 px, 93 KB)

The two comments at the bottom are pre-fix, and exhibit the bug. The comment at the top is post-fix, and appears adjacent to the original correctly.

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11116
Build 13770: Run Core Tests
Build 13769: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When replying to a ghost comment, attach the reply to the same place.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2016, 12:13 AM
This revision was automatically updated to reflect the committed changes.