Paths

Table of Contentst

Cast old duration values for unit tests to float in DifferentialController
ClosedPublic
Actions

Authored by BYK on Mar 9 2016, 11:04 PM.

Details

Reviewers

epriestley
avivey

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10549: Getting PhutilTypeCheckException on certaion Differential pages

Commits

Restricted Diffusion Commit
rP60b42750b641: Cast old duration values for unit tests to float in DifferentialController

Summary

Fixes T10549.

Test Plan

N/A

Diff Detail

Repository

rP Phabricator

Branch

fix-duration

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 11104
Build 13751: arc lint + arc unit

Event Timeline

BYK updated this revision to Diff 37242.Mar 9 2016, 11:04 PM

BYK retitled this revision from to Cast old duration values for unit tests to float in DifferentialController.

BYK updated this object.

BYK edited the test plan for this revision. (Show Details)

BYK added reviewers: avivey, epriestley.

BYK added a task: T10549: Getting PhutilTypeCheckException on certaion Differential pages.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 9 2016, 11:04 PM

Herald added a subscriber: Korvin. · View Herald Transcript

This should probably test that duration actually exists. Also not sure why it cropped up now, but whatever. I'll tweak it in the pull.

This revision is now accepted and ready to land.Mar 11 2016, 2:12 AM

I am also making a vaguely related fix I caught elsewhere because I am a loose cannon with no respect for the rules.

+    if (!$diff->getBuildable()) {
+      return null;
+    }

Closed by commit rP60b42750b641: Cast old duration values for unit tests to float in DifferentialController (authored by BYK, committed by epriestley). · Explain WhyMar 11 2016, 2:16 AM

This revision was automatically updated to reflect the committed changes.

BYK added inline comments.Mar 11 2016, 8:36 AM

src/applications/differential/controller/DifferentialController.php
195	I swear I thought about this but then since it didn't break on our system, I thought it wasn't necessary. Anyways, thanks!

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialController.php

3 lines

Diff 37242

View Options

src/applications/differential/controller/DifferentialController.php

Cast old duration values for unit tests to float in DifferentialControllerClosedPublicActions