Differential D15390

Convert DrydockBlueprints to EditEngine
ClosedPublic
Actions

Authored by epriestley on Mar 3 2016, 1:44 PM.

Details

Reviewers

chad

Maniphest Tasks

T10024: Can't remove blueprint limit
T10457: Improve Harbomaster/Drydock UI/UX before release

Commits

Restricted Diffusion Commit
rP1bdf9885562e: Convert DrydockBlueprints to EditEngine

Summary

Ref T10457. Fixes T10024. This primarily just modernizes blueprints to use EditEngine.

This also fixes T10024, which was an issue with stored properties not being flagged correctly.

Also slightly improves typeaheads for blueprints (more information, disabled state).

Test Plan

Created and edited various types of blueprints.
Set and removed limits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37105.Mar 3 2016, 1:44 PM

epriestley retitled this revision from to Convert DrydockBlueprints to EditEngine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10457: Improve Harbomaster/Drydock UI/UX before release, T10024: Can't remove blueprint limit.

chad accepted this revision.Mar 3 2016, 4:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2016, 4:35 PM

Closed by commit rP1bdf9885562e: Convert DrydockBlueprints to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2016, 11:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

drydock/

application/

PhabricatorDrydockApplication.php

4 lines

controller/

DrydockBlueprintController.php

16 lines

DrydockBlueprintCreateController.php

DrydockBlueprintEditController.php

191 lines

DrydockBlueprintListController.php

15 lines

customfield/

DrydockBlueprintCoreCustomField.php

1 line

editor/

DrydockBlueprintEditEngine.php

115 lines

DrydockBlueprintEditor.php

32 lines

typeahead/

DrydockBlueprintDatasource.php

15 lines

transactions/

editfield/

PhabricatorStaticEditField.php

18 lines

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldCredential.php

12 lines

PhabricatorStandardCustomFieldTokenizer.php

12 lines

Diff 37114

View Options

src/__phutil_library_map__.php

View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

View Options

src/applications/drydock/controller/DrydockBlueprintController.php

View Options

src/applications/drydock/controller/DrydockBlueprintCreateController.php

View Options

src/applications/drydock/controller/DrydockBlueprintEditController.php

View Options

src/applications/drydock/controller/DrydockBlueprintListController.php

View Options

src/applications/drydock/customfield/DrydockBlueprintCoreCustomField.php

View Options

src/applications/drydock/editor/DrydockBlueprintEditEngine.php

View Options

src/applications/drydock/editor/DrydockBlueprintEditor.php

View Options

src/applications/drydock/typeahead/DrydockBlueprintDatasource.php

View Options

src/applications/transactions/editfield/PhabricatorStaticEditField.php

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Convert DrydockBlueprints to EditEngineClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37114

src/__phutil_library_map__.php

src/applications/drydock/application/PhabricatorDrydockApplication.php

src/applications/drydock/controller/DrydockBlueprintController.php

src/applications/drydock/controller/DrydockBlueprintCreateController.php

src/applications/drydock/controller/DrydockBlueprintEditController.php

src/applications/drydock/controller/DrydockBlueprintListController.php

src/applications/drydock/customfield/DrydockBlueprintCoreCustomField.php

src/applications/drydock/editor/DrydockBlueprintEditEngine.php

src/applications/drydock/editor/DrydockBlueprintEditor.php

src/applications/drydock/typeahead/DrydockBlueprintDatasource.php

src/applications/transactions/editfield/PhabricatorStaticEditField.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Convert DrydockBlueprints to EditEngine
ClosedPublic
Actions

Revision Contents
Changeset List