Page MenuHomePhabricator
Differential D15390

Convert DrydockBlueprints to EditEngine
ClosedPublic
Actions

Authored by epriestley on Mar 3 2016, 1:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 1:23 AM
Unknown Object (File)
Mon, Dec 23, 1:23 AM
Unknown Object (File)
Mon, Dec 23, 1:23 AM
Unknown Object (File)
Mon, Dec 23, 1:23 AM
Unknown Object (File)
Fri, Dec 20, 9:07 AM
Unknown Object (File)
Mon, Dec 16, 11:50 PM
Unknown Object (File)
Sun, Dec 15, 9:51 PM
Unknown Object (File)
Sun, Dec 15, 7:38 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10024: Can't remove blueprint limit
T10457: Improve Harbomaster/Drydock UI/UX before release
Commits
Restricted Diffusion Commit
rP1bdf9885562e: Convert DrydockBlueprints to EditEngine
Summary

Ref T10457. Fixes T10024. This primarily just modernizes blueprints to use EditEngine.

This also fixes T10024, which was an issue with stored properties not being flagged correctly.

Also slightly improves typeaheads for blueprints (more information, disabled state).

Test Plan
  • Created and edited various types of blueprints.
  • Set and removed limits.

Diff Detail

Repository
rP Phabricator
Branch
dry19
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10962
Build 13537: Run Core Tests
Build 13536: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37105.Mar 3 2016, 1:44 PM
epriestley retitled this revision from to Convert DrydockBlueprints to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10457: Improve Harbomaster/Drydock UI/UX before release, T10024: Can't remove blueprint limit.
chad accepted this revision.Mar 3 2016, 4:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 4:35 PM
Closed by commit rP1bdf9885562e: Convert DrydockBlueprints to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2016, 11:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37105

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

Loading...
View Options

src/applications/drydock/controller/DrydockBlueprintController.php

Loading...
View Options

src/applications/drydock/controller/DrydockBlueprintCreateController.php

Loading...
View Options

src/applications/drydock/controller/DrydockBlueprintEditController.php

Loading...
View Options

src/applications/drydock/controller/DrydockBlueprintListController.php

Loading...
View Options

src/applications/drydock/customfield/DrydockBlueprintCoreCustomField.php

Loading...
View Options

src/applications/drydock/editor/DrydockBlueprintEditEngine.php

Loading...
View Options

src/applications/drydock/editor/DrydockBlueprintEditor.php

Loading...
View Options

src/applications/drydock/typeahead/DrydockBlueprintDatasource.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorStaticEditField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Loading...
Phabricator · Built by Phacility