Page MenuHomePhabricator
Differential D15391

Fix overzealous transactions on dashboard panels
ClosedPublic
Actions

Authored by epriestley on Mar 3 2016, 1:47 PM.
Tags
None
Referenced Files
F15398892: D15391.diff
Mon, Mar 17, 1:52 AM
F15395427: D15391.id37109.diff
Sun, Mar 16, 6:57 AM
F15386134: D15391.id37106.diff
Sat, Mar 15, 12:06 AM
F15386133: D15391.id37109.diff
Sat, Mar 15, 12:06 AM
F15374344: D15391.id37109.diff
Wed, Mar 12, 6:38 PM
F15354340: D15391.diff
Tue, Mar 11, 3:33 AM
F15343239: D15391.id37109.diff
Sun, Mar 9, 10:15 PM
F15336308: D15391.id37109.diff
Sat, Mar 8, 6:40 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10474: Dashboard panel changes seem to think every edit creates whole text all over again
Commits
Restricted Diffusion Commit
rPac729278328e: Fix overzealous transactions on dashboard panels
Summary

Fixes T10474. This had the same root cause as T10024 -- a missing call to didSetValueFromStorage() because of the way the fields work.

Test Plan
  • Edited a text panel before change, without changing text: got silly transaction.
  • Made change, edited text panel without changing text, no transaction.
  • Made a real edit, got a good transaction.

Diff Detail

Repository
rP Phabricator
Branch
dry20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10963
Build 13539: Run Core Tests
Build 13538: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37106.Mar 3 2016, 1:47 PM
epriestley retitled this revision from to Fix overzealous transactions on dashboard panels.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10474: Dashboard panel changes seem to think every edit creates whole text all over again.
epriestley mentioned this in T10474: Dashboard panel changes seem to think every edit creates whole text all over again.Mar 3 2016, 1:48 PM
chad accepted this revision.Mar 3 2016, 3:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 3:32 PM
Closed by commit rPac729278328e: Fix overzealous transactions on dashboard panels (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2016, 3:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
customfield/
1 line

Diff 37106

View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelCoreCustomField.php

Loading...
Phabricator · Built by Phacility