Page MenuHomePhabricator
Differential D15365

Give unit test results their own table in Differential
ClosedPublic
Actions

Authored by epriestley on Feb 29 2016, 5:56 PM.
Tags
None
Referenced Files
F14059616: D15365.id37047.diff
Sun, Nov 17, 8:42 PM
F14059615: D15365.id37045.diff
Sun, Nov 17, 8:42 PM
F14059614: D15365.id37046.diff
Sun, Nov 17, 8:42 PM
F14054773: D15365.diff
Sat, Nov 16, 4:44 AM
F14042305: D15365.diff
Tue, Nov 12, 2:22 AM
F14029242: D15365.id37046.diff
Fri, Nov 8, 8:18 PM
F14029057: D15365.id37046.diff
Fri, Nov 8, 7:07 PM
F14028922: D15365.diff
Fri, Nov 8, 5:56 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10457: Improve Harbomaster/Drydock UI/UX before release
Commits
Restricted Diffusion Commit
rP181e030535f6: Give unit test results their own table in Differential
Summary

Ref T10457. This gives unit test results a more first-class treatment in the Differential UI, and consolidates some rendering code.

Test Plan

Before:

Screen Shot 2016-02-29 at 9.53.54 AM.png (1×1 px, 344 KB)

After:

Screen Shot 2016-02-29 at 9.54.02 AM.png (1×1 px, 341 KB)

Diff Detail

Repository
rP Phabricator
Branch
dry11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10886
Build 13428: Run Core Tests
Build 13427: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37045.Feb 29 2016, 5:56 PM
epriestley retitled this revision from to Give unit test results their own table in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10457: Improve Harbomaster/Drydock UI/UX before release.
Herald edited edge metadata. · View Herald TranscriptFeb 29 2016, 5:56 PM
epriestley updated this revision to Diff 37046.Feb 29 2016, 5:57 PM
epriestley edited edge metadata.
  • Small fix for legacy messages: only link test results if we're examining a concrete (vs synthetic) result.
Herald edited edge metadata. · View Herald TranscriptFeb 29 2016, 5:57 PM
chad added inline comments.Feb 29 2016, 8:15 PM
src/applications/harbormaster/view/HarbormasterUnitSummaryView.php
72

I believe you can just pass a note to objectbox or aphront table, if I remember right. We use it in Legalpad, and would be a little cleaner layout wise.

pasted_file (242×676 px, 47 KB)

epriestley added a comment.Feb 29 2016, 8:20 PM

Hmm, it's currently implemented as a <td /> above the first row, which breaks table-layout: fixed:

Screen Shot 2016-02-29 at 12.19.28 PM.png (156×1 px, 31 KB)

epriestley updated this revision to Diff 37047.Feb 29 2016, 8:24 PM
epriestley edited edge metadata.
  • Implement setNotice() using a <div /> above the table.
  • Legalpad, etc., still look normal.
  • "Excuse" now looks a little better:

Screen Shot 2016-02-29 at 12.24.10 PM.png (300×634 px, 48 KB)

Herald edited edge metadata. · View Herald TranscriptFeb 29 2016, 8:24 PM
chad accepted this revision.Feb 29 2016, 8:25 PM
chad edited edge metadata.

Okies.

This revision is now accepted and ready to land.Feb 29 2016, 8:25 PM
Closed by commit rP181e030535f6: Give unit test results their own table in Differential (authored by epriestley, committed by epriestley). · Explain WhyFeb 29 2016, 10:27 PM
This revision was automatically updated to reflect the committed changes.
BYK mentioned this in T10549: Getting PhutilTypeCheckException on certaion Differential pages.Mar 9 2016, 10:05 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
4 lines
applications/
differential/
controller/
126 lines
76 lines
customfield/
91 lines
storage/
27 lines
harbormaster/
controller/
39 lines
8 lines
view/
18 lines
103 lines
webroot/
rsrc/
css/
aphront/
4 lines

Diff 37046

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterUnitMessageListController.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitPropertyView.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitSummaryView.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
Phabricator · Built by Phacility