Ref T10457. This gives unit test results a more first-class treatment in the Differential UI, and consolidates some rendering code.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T10457: Improve Harbomaster/Drydock UI/UX before release
- Commits
- Restricted Diffusion Commit
rP181e030535f6: Give unit test results their own table in Differential
Before:
After:
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dry11
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10887 Build 13430: Run Core Tests Build 13429: arc lint + arc unit
Event Timeline
Comment Actions
- Small fix for legacy messages: only link test results if we're examining a concrete (vs synthetic) result.
| src/applications/harbormaster/view/HarbormasterUnitSummaryView.php | ||
|---|---|---|
| 73 | I believe you can just pass a note to objectbox or aphront table, if I remember right. We use it in Legalpad, and would be a little cleaner layout wise. | |
Comment Actions
Hmm, it's currently implemented as a <td /> above the first row, which breaks table-layout: fixed:
Comment Actions
- Implement setNotice() using a <div /> above the table.
- Legalpad, etc., still look normal.
- "Excuse" now looks a little better:
