Differential D15344

Fix two issues with callsign-free repositories
ClosedPublic
Actions

Authored by epriestley on Feb 25 2016, 11:09 AM.

Details

Reviewers

chad

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rP5b9d8aeae701: Fix two issues with callsign-free repositories

Summary

Ref T4245. These callsites don't quite do the right thing if a repository has no callsign.

Test Plan

Made a comment on a commit in a repository with no callsign.

Diff Detail

Repository

rP Phabricator

Branch

monogram

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10841
Build 13362: Run Core Tests
Build 13361: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37002.Feb 25 2016, 11:09 AM

epriestley retitled this revision from to Fix two issues with callsign-free repositories.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4245: Make repository URIs slightly prettier.

chad accepted this revision.Feb 25 2016, 2:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 25 2016, 2:47 PM

Closed by commit rP5b9d8aeae701: Fix two issues with callsign-free repositories (authored by epriestley, committed by epriestley). · Explain WhyFeb 26 2016, 2:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

controller/

PhabricatorAuditAddCommentController.php

4 lines

diffusion/

controller/

DiffusionExternalController.php

2 lines

Diff 37002

View Options

src/applications/audit/controller/PhabricatorAuditAddCommentController.php