Page MenuHomePhabricator
Differential D15326

Use EditEngine for Almanac Services, Devices, and Networks
ClosedPublic
Actions

Authored by epriestley on Feb 22 2016, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 4:00 AM
Unknown Object (File)
Fri, Jan 31, 7:57 PM
Unknown Object (File)
Thu, Jan 30, 1:06 PM
Unknown Object (File)
Tue, Jan 28, 1:00 AM
Unknown Object (File)
Fri, Jan 24, 11:57 AM
Unknown Object (File)
Fri, Jan 24, 11:57 AM
Unknown Object (File)
Fri, Jan 24, 11:57 AM
Unknown Object (File)
Fri, Jan 24, 11:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10411: Modernize Almanac to support EditEngine
Commits
Restricted Diffusion Commit
rP24104be67d1a: Use EditEngine for Almanac Services, Devices, and Networks
Summary

Ref T10411. This cleans up / modernizes things and lets me get an almanac.network.edit API in the future.

This is mostly straightforward, except that Services have an extra "choose type" screen in front of them.

Test Plan
  • Created and edited Almanac networks, services, and devices.

Diff Detail

Repository
rP Phabricator
Branch
almanac8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10807
Build 13312: Run Core Tests
Build 13311: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36965.Feb 22 2016, 1:22 PM
epriestley retitled this revision from to Use EditEngine for AlmanacNetworks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10411: Modernize Almanac to support EditEngine.
epriestley planned changes to this revision.Feb 22 2016, 1:55 PM

I need to deal with custom fields and the mess in T10410 first.

epriestley mentioned this in D15327: Allow Almanac properties to be deleted, use EditEngine instead of CustomField.Feb 22 2016, 4:18 PM
epriestley updated this revision to Diff 36967.Feb 22 2016, 4:28 PM
  • Rebase on D15327 so CustomFields no longer autogenerates a billion extra fields everywhere.
epriestley retitled this revision from Use EditEngine for AlmanacNetworks to Use EditEngine for Almanac Services, Devices, and Networks.Feb 22 2016, 4:30 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
chad accepted this revision.Feb 22 2016, 5:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 22 2016, 5:18 PM
Closed by commit rP24104be67d1a: Use EditEngine for Almanac Services, Devices, and Networks (authored by epriestley, committed by epriestley). · Explain WhyFeb 22 2016, 7:28 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rPab86523ac490: Allow Almanac properties to be deleted, use EditEngine instead of CustomField.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

Diff 36967

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/controller/AlmanacNamespaceEditController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacNetworkEditController.php

Loading...
View Options

src/applications/almanac/editor/AlmanacNetworkEditEngine.php

Loading...
View Options

src/applications/almanac/storage/AlmanacNetworkTransaction.php

Loading...
Phabricator · Built by Phacility