Page MenuHomePhabricator

Allow Almanac properties to be deleted, use EditEngine instead of CustomField

Authored by epriestley on Feb 22 2016, 4:18 PM.
Referenced Files
F12181376: D15327.id36968.diff
Tue, Sep 12, 7:51 PM
F12180844: D15327.id36968.diff
Tue, Sep 12, 2:58 PM
F12180841: D15327.id36966.diff
Tue, Sep 12, 2:58 PM
Tue, Sep 12, 2:57 PM
F12180836: D15327.diff
Tue, Sep 12, 2:57 PM
F12168409: D15327.diff
Thu, Sep 7, 4:32 AM
F12139688: D15327.id36966.diff
Aug 28 2023, 8:25 AM
F12135070: D15327.diff
Aug 25 2023, 9:00 AM



Fixes T10410. Immediate impact of this is that you can now actually delete properties from Almanac services, devices and bindings.

The meat of the change is switching from CustomField to EditEngine for most of the actual editing logic. CustomField creates a lot of problems with using EditEngine for everything else (D15326), and weird, hard-to-resolve bugs like this one (not being able to delete stuff).

Using EditEngine to do this stuff instead seems like it works out much better -- I did this in ProfilePanel first and am happy with how it looks.

This also makes the internal storage for properties JSON instead of raw text.

Test Plan
  • Created, edited and deleted properties on services, devices and bindings.
  • Edited and reset builtin properties on repository services.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Almanac properties to be deleted, use EditEngine instead of CustomField.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 22 2016, 6:13 PM
This revision was automatically updated to reflect the committed changes.