Page MenuHomePhabricator

Allow Almanac properties to be deleted, use EditEngine instead of CustomField
ClosedPublic

Authored by epriestley on Feb 22 2016, 4:18 PM.
Tags
None
Referenced Files
F12834583: D15327.diff
Thu, Mar 28, 2:41 PM
Unknown Object (File)
Mon, Mar 4, 6:09 PM
Unknown Object (File)
Mon, Mar 4, 6:08 PM
Unknown Object (File)
Mon, Mar 4, 6:08 PM
Unknown Object (File)
Mon, Mar 4, 6:08 PM
Unknown Object (File)
Feb 16 2024, 3:56 PM
Unknown Object (File)
Feb 15 2024, 9:09 PM
Unknown Object (File)
Feb 15 2024, 7:24 AM
Subscribers
None

Details

Summary

Fixes T10410. Immediate impact of this is that you can now actually delete properties from Almanac services, devices and bindings.

The meat of the change is switching from CustomField to EditEngine for most of the actual editing logic. CustomField creates a lot of problems with using EditEngine for everything else (D15326), and weird, hard-to-resolve bugs like this one (not being able to delete stuff).

Using EditEngine to do this stuff instead seems like it works out much better -- I did this in ProfilePanel first and am happy with how it looks.

This also makes the internal storage for properties JSON instead of raw text.

Test Plan
  • Created, edited and deleted properties on services, devices and bindings.
  • Edited and reset builtin properties on repository services.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Almanac properties to be deleted, use EditEngine instead of CustomField.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 22 2016, 6:13 PM
This revision was automatically updated to reflect the committed changes.