Page MenuHomePhabricator

Use EditEngine for Almanac Services, Devices, and Networks
ClosedPublic

Authored by epriestley on Feb 22 2016, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 10:03 PM
Unknown Object (File)
Feb 24 2024, 2:16 AM
Unknown Object (File)
Feb 13 2024, 1:06 PM
Unknown Object (File)
Feb 9 2024, 3:11 AM
Unknown Object (File)
Feb 6 2024, 8:12 PM
Unknown Object (File)
Feb 3 2024, 8:52 AM
Unknown Object (File)
Jan 23 2024, 10:19 AM
Unknown Object (File)
Jan 9 2024, 8:00 PM
Subscribers
None

Details

Summary

Ref T10411. This cleans up / modernizes things and lets me get an almanac.network.edit API in the future.

This is mostly straightforward, except that Services have an extra "choose type" screen in front of them.

Test Plan
  • Created and edited Almanac networks, services, and devices.

Diff Detail

Repository
rP Phabricator
Branch
almanac7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10805
Build 13308: Run Core Tests
Build 13307: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use EditEngine for AlmanacNetworks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I need to deal with custom fields and the mess in T10410 first.

  • Rebase on D15327 so CustomFields no longer autogenerates a billion extra fields everywhere.
epriestley retitled this revision from Use EditEngine for AlmanacNetworks to Use EditEngine for Almanac Services, Devices, and Networks.Feb 22 2016, 4:30 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 22 2016, 5:18 PM