Page MenuHomePhabricator
Differential D15319

Allow Almanac devices to be queried and sorted by name
ClosedPublic
Actions

Authored by epriestley on Feb 21 2016, 10:59 AM.
Tags
None
Referenced Files
F14813052: D15319.diff
Mon, Jan 27, 9:47 AM
Unknown Object (File)
Sat, Jan 25, 8:21 PM
Unknown Object (File)
Sat, Jan 25, 1:47 PM
Unknown Object (File)
Fri, Jan 24, 2:01 PM
Unknown Object (File)
Fri, Jan 24, 11:56 AM
Unknown Object (File)
Wed, Jan 22, 6:35 AM
Unknown Object (File)
Wed, Jan 22, 1:58 AM
Unknown Object (File)
Fri, Jan 17, 5:34 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10205: Support browsing interface names in Almanac typehaead
T10246: Deploy Drydock in the Phacility cluster
Commits
Restricted Diffusion Commit
rP1b6ddae6b2d8: Allow Almanac devices to be queried and sorted by name
Summary

Ref T10205. Ref T10246. This is general modernization, but also supports fixing the interface datasource in T10205.

  • Update Query.
  • Update SearchEngine.
  • Use an ngrams index for searching names efficiently.
Test Plan
  • Ran migrations.
  • Searched Almanac devices by name.
  • Created a new device, searched for it by name.

Screen Shot 2016-02-21 at 2.57.36 AM.png (643×1 px, 106 KB)

Diff Detail

Repository
rP Phabricator
Branch
almanac1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10789
Build 13284: Run Core Tests
Build 13283: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36949.Feb 21 2016, 10:59 AM
epriestley retitled this revision from to Allow Almanac devices to be queried and sorted by name.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10246: Deploy Drydock in the Phacility cluster, T10205: Support browsing interface names in Almanac typehaead.
chad accepted this revision.Feb 21 2016, 3:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2016, 3:42 PM
Closed by commit rP1b6ddae6b2d8: Allow Almanac devices to be queried and sorted by name (authored by epriestley, committed by epriestley). · Explain WhyFeb 21 2016, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
7 lines
11 lines
src/
3 lines
applications/
almanac/
customfield/
3 lines
editor/
6 lines
query/
82 lines
31 lines
storage/
14 lines
18 lines

Diff 36949

View Options

resources/sql/autopatches/20160221.almanac.1.devicen.sql

Loading...
View Options

resources/sql/autopatches/20160221.almanac.2.devicei.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/customfield/AlmanacCoreCustomField.php

Loading...
View Options

src/applications/almanac/editor/AlmanacDeviceEditor.php

Loading...
View Options

src/applications/almanac/query/AlmanacDeviceQuery.php

Loading...
View Options

src/applications/almanac/query/AlmanacDeviceSearchEngine.php

Loading...
View Options

src/applications/almanac/storage/AlmanacDevice.php

Loading...
View Options

src/applications/almanac/storage/AlmanacDeviceNameNgrams.php

Loading...
Phabricator · Built by Phacility