Page MenuHomePhabricator
Differential D15308

Move Diffusion ReadmeView to PHUIDocumentProView
ClosedPublic
Actions

Authored by chad on Feb 19 2016, 3:48 AM.
Tags
None
Referenced Files
F13152669: D15308.diff
Sat, May 4, 8:49 PM
F13148877: D15308.diff
Sat, May 4, 5:06 AM
Unknown Object (File)
Wed, May 1, 12:59 AM
Unknown Object (File)
Sun, Apr 14, 9:59 PM
Unknown Object (File)
Thu, Apr 11, 1:37 AM
Unknown Object (File)
Wed, Apr 10, 3:11 PM
Unknown Object (File)
Apr 2 2024, 4:10 AM
Unknown Object (File)
Apr 1 2024, 2:41 PM
View All Files
Subscribers
avivey
Korvin

Details

Reviewers
epriestley
avivey
Commits
Restricted Diffusion Commit
rP5eecff91cdd3: Move Diffusion ReadmeView to PHUIDocumentProView
Summary

Swapping out to PHUIDocumentProView to remove all calls to PHUIDocumentView.

Test Plan

Review the Phabricator Readme.MD in Diffusion

Diff Detail

Repository
rP Phabricator
Branch
diffusion-readme (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10770
Build 13259: Run Core Tests
Build 13258: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36926.Feb 19 2016, 3:48 AM
chad retitled this revision from to Move Diffusion ReadmeView to PHUIDocumentProView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 19 2016, 3:48 AM
chad added inline comments.Feb 19 2016, 3:50 AM
src/applications/diffusion/view/DiffusionReadmeView.php
118

I must have "spaced" here.

chad updated this revision to Diff 36927.Feb 19 2016, 3:52 AM
  • spaceing
chad added a comment.Feb 19 2016, 4:03 AM

My github streak is at steak!

avivey accepted this revision.Feb 19 2016, 4:17 AM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

I think the space is OK now.

This revision is now accepted and ready to land.Feb 19 2016, 4:17 AM
Closed by commit rP5eecff91cdd3: Move Diffusion ReadmeView to PHUIDocumentProView (authored by chad, committed by chad). · Explain WhyFeb 19 2016, 4:18 AM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
diffusion/
view/
11 lines
webroot/
rsrc/
css/
application/
diffusion/
13 lines

Diff 36927

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/view/DiffusionReadmeView.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-readme.css

Loading...
Phabricator · Built by Phacility