Page MenuHomePhabricator

Make repository callsigns optional
ClosedPublic

Authored by epriestley on Feb 18 2016, 2:20 PM.
Tags
None
Referenced Files
F14055374: D15305.diff
Sat, Nov 16, 11:08 AM
F14046885: D15305.id36914.diff
Thu, Nov 14, 12:34 AM
F14045867: D15305.id36914.diff
Wed, Nov 13, 2:35 PM
F14042751: D15305.diff
Tue, Nov 12, 5:50 AM
F14039264: D15305.id36915.diff
Mon, Nov 11, 4:50 AM
F14039263: D15305.id36914.diff
Mon, Nov 11, 4:50 AM
F14036563: D15305.id36924.diff
Sun, Nov 10, 10:48 AM
F14035376: D15305.id36924.diff
Sun, Nov 10, 5:40 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by techdragon.

Details

Summary

Ref T4245. This could still use a little UI smoothing, but:

  • Don't require a callsign on the create flow (you can add one later in "Edit Basic Information" if you want).
  • Allow existing callsigns to be removed.
Test Plan
  • Created a new repository with no callsign.
  • Cloned it; pushed to it.
  • Browsed around Diffusion a bunch.
  • Visited a commit URI.
  • Added a callsign to it.
  • Removed the callsign again.
  • Referenced it with R22 in remarkup.

Diff Detail

Repository
rP Phabricator
Branch
call11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10758
Build 13244: Run Core Tests
Build 13243: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36915.
epriestley retitled this revision from to Make repository callsigns optional.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix one issue with {abcdef} on a hash in a callsign-free repository.
chad edited edge metadata.

This could still use a little UI smoothing

imgres.jpg (225×225 px, 8 KB)

This revision is now accepted and ready to land.Feb 18 2016, 4:20 PM
This revision was automatically updated to reflect the committed changes.