Paths

Table of Contentst

Differential D15302

Make serving repositories work with alternate URIs
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 1:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 6, 10:24 PM

	Unknown Object (File)
	Fri, Dec 6, 8:37 PM

	Unknown Object (File)
	Fri, Dec 6, 1:46 AM

	Unknown Object (File)
	Wed, Dec 4, 9:50 AM

	Unknown Object (File)
	Tue, Dec 3, 9:02 PM

	Unknown Object (File)
	Thu, Nov 28, 1:27 AM

	Unknown Object (File)
	Wed, Nov 20, 11:38 AM

	Unknown Object (File)
	Nov 16 2024, 10:39 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rP74a79aa634ef: Make serving repositories work with alternate URIs

Summary

Ref T4245. Consolidates the URI parsing/rewriting logic so that repositories can be served from either /diffusion/XYZ/ or /diffusion/123/, over both HTTP and SSH.

Test Plan

Pulled a Git repository by ID and callsign over HTTP and SSH.
Pulled a Mercurial repository by ID and callsign over HTTP and SSH.
Pulled a Subversion repository by ID and callsign over SSH (no HTTP support for SVN).

Diff Detail

Repository

Branch

call8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10754
Build 13236: Run Core Tests
Build 13235: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36911.Feb 18 2016, 1:11 PM

epriestley retitled this revision from to Make serving repositories work with alternate URIs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4245: Make repository URIs slightly prettier.

epriestley mentioned this in T4245: Make repository URIs slightly prettier.Feb 18 2016, 1:16 PM

readImage.jpg (425×620 px, 24 KB)

This revision is now accepted and ready to land.Feb 18 2016, 4:16 PM

Closed by commit rP74a79aa634ef: Make serving repositories work with alternate URIs (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 6:06 PM

This revision was automatically updated to reflect the committed changes.

• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM

tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

16 lines

ssh/

DiffusionSSHWorkflow.php

31 lines

DiffusionSubversionServeSSHWorkflow.php

14 lines

repository/

storage/

PhabricatorRepository.php

35 lines

Diff 36911

src/applications/diffusion/controller/DiffusionServeController.php

Loading...

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...