Page MenuHomePhabricator
Differential D15302

Make serving repositories work with alternate URIs
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 1:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:27 AM
Unknown Object (File)
Sun, Apr 21, 9:48 PM
Unknown Object (File)
Fri, Apr 19, 4:12 PM
Unknown Object (File)
Mon, Apr 15, 8:57 PM
Unknown Object (File)
Mar 23 2024, 5:57 PM
Unknown Object (File)
Mar 23 2024, 5:56 PM
Unknown Object (File)
Mar 23 2024, 5:56 PM
Unknown Object (File)
Mar 22 2024, 10:37 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP74a79aa634ef: Make serving repositories work with alternate URIs
Summary

Ref T4245. Consolidates the URI parsing/rewriting logic so that repositories can be served from either /diffusion/XYZ/ or /diffusion/123/, over both HTTP and SSH.

Test Plan
  • Pulled a Git repository by ID and callsign over HTTP and SSH.
  • Pulled a Mercurial repository by ID and callsign over HTTP and SSH.
  • Pulled a Subversion repository by ID and callsign over SSH (no HTTP support for SVN).

Diff Detail

Repository
rP Phabricator
Branch
call8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10754
Build 13236: Run Core Tests
Build 13235: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36911.Feb 18 2016, 1:11 PM
epriestley retitled this revision from to Make serving repositories work with alternate URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
epriestley mentioned this in T4245: Make repository URIs slightly prettier.Feb 18 2016, 1:16 PM
chad accepted this revision.Feb 18 2016, 4:16 PM
chad edited edge metadata.

readImage.jpg (425×620 px, 24 KB)

This revision is now accepted and ready to land.Feb 18 2016, 4:16 PM
Closed by commit rP74a79aa634ef: Make serving repositories work with alternate URIs (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 6:06 PM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
16 lines
ssh/
31 lines
14 lines
repository/
storage/
35 lines

Diff 36911

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility