Page MenuHomePhabricator

Support ID-based repository URIs, and canonicalize repository URIs
ClosedPublic

Authored by epriestley on Feb 18 2016, 12:22 PM.
Tags
None
Referenced Files
F18105512: D15301.id.diff
Sun, Aug 10, 6:26 PM
F18105511: D15301.id36920.diff
Sun, Aug 10, 6:26 PM
F18105510: D15301.id36908.diff
Sun, Aug 10, 6:26 PM
F18105509: D15301.id36909.diff
Sun, Aug 10, 6:25 PM
F18105508: D15301.id36910.diff
Sun, Aug 10, 6:25 PM
F18105397: D15301.diff
Sun, Aug 10, 5:53 PM
F18085796: D15301.id.diff
Tue, Aug 5, 7:25 PM
Unknown Object (File)
Jul 2 2025, 5:20 PM
Subscribers
None

Details

Summary

Ref T4245. Make /diffusion/123/ work, but redirect the user to /diffusion/XYZ/ if the repository has a callsign.

(Right now, every repository has a callsign, so this always redirects.)

Also redirect /R123:abcdef if the repository has a callsign.

Also also, move the Pull garbage collector somewhere more sensible.

Test Plan
  • Added test coverage.
  • Visited /diffusion/1/, was redirected.
  • Visited /diffusion/R1:abcdef, was redirected.
  • Browsed Diffusion normally.

Diff Detail

Repository
rP Phabricator
Branch
call7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10753
Build 13234: Run Core Tests
Build 13233: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Support ID-based repository URIs, and canonicalize repository URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix bad regex for repositories with multiple-digit IDs, like "18".
  • Also fix the other copy of the dodgy regexp.
This revision is now accepted and ready to land.Feb 18 2016, 4:14 PM
This revision was automatically updated to reflect the committed changes.