Page MenuHomePhabricator
Differential D15301

Support ID-based repository URIs, and canonicalize repository URIs
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 12:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:13 AM
Unknown Object (File)
Thu, Dec 19, 4:56 AM
Unknown Object (File)
Tue, Dec 17, 9:27 AM
Unknown Object (File)
Fri, Dec 13, 6:33 PM
Unknown Object (File)
Tue, Dec 10, 11:56 AM
Unknown Object (File)
Sat, Dec 7, 4:03 AM
Unknown Object (File)
Sat, Dec 7, 2:51 AM
Unknown Object (File)
Fri, Dec 6, 12:42 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPc2b8dd28d885: Support ID-based repository URIs, and canonicalize repository URIs
Summary

Ref T4245. Make /diffusion/123/ work, but redirect the user to /diffusion/XYZ/ if the repository has a callsign.

(Right now, every repository has a callsign, so this always redirects.)

Also redirect /R123:abcdef if the repository has a callsign.

Also also, move the Pull garbage collector somewhere more sensible.

Test Plan
  • Added test coverage.
  • Visited /diffusion/1/, was redirected.
  • Visited /diffusion/R1:abcdef, was redirected.
  • Browsed Diffusion normally.

Diff Detail

Repository
rP Phabricator
Branch
call7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10752
Build 13232: Run Core Tests
Build 13231: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36908.Feb 18 2016, 12:22 PM
epriestley retitled this revision from to Support ID-based repository URIs, and canonicalize repository URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
epriestley updated this revision to Diff 36909.Feb 18 2016, 12:41 PM
  • Fix bad regex for repositories with multiple-digit IDs, like "18".
epriestley updated this revision to Diff 36910.Feb 18 2016, 12:43 PM
  • Also fix the other copy of the dodgy regexp.
chad accepted this revision.Feb 18 2016, 4:14 PM
chad edited edge metadata.

084.png (256×300 px, 101 KB)

This revision is now accepted and ready to land.Feb 18 2016, 4:14 PM
Closed by commit rPc2b8dd28d885: Support ID-based repository URIs, and canonicalize repository URIs (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
application/
11 lines
controller/
14 lines
garbagecollector/
29 lines
repository/
storage/
49 lines
__tests__/
41 lines

Diff 36909

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/DiffusionPullEventGarbageCollector.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/garbagecollector/DiffusionPullEventGarbageCollector.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/__tests__/PhabricatorRepositoryURITestCase.php

Loading...
Phabricator · Built by Phacility