Paths

Table of Contentst

Differential D15296

Make `bin/diviner generate --repository <repository>` accept identifiers
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 1:21 AM.

Tags

None

Referenced Files

	F19153598: D15296.id.diff
	Dec 11 2025, 11:08 AM

	F19135852: D15296.diff
	Dec 10 2025, 9:12 AM

	F19086081: D15296.id36901.diff
	Dec 2 2025, 8:39 PM

	F19086080: D15296.id36902.diff
	Dec 2 2025, 8:39 PM

	F19086001: D15296.diff
	Dec 2 2025, 8:13 PM

	F19069809: D15296.id36901.diff
	Nov 30 2025, 3:05 PM

	F19069640: D15296.diff
	Nov 30 2025, 2:53 PM

	F18904396: D15296.diff
	Nov 8 2025, 9:06 AM

Subscribers

None

Details

Reviewers

avivey
chad

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rP097bcb397061: Make `bin/diviner generate --repository <repository>` accept identifiers

Summary

Ref T4245. This currently accepts only callsigns; prepare it for the bright new callsign-optional world.

Test Plan

Ran ./bin/diviner generate --repository 1 --book src/docs/book/flavor.book --clean, got a good result.
Ran ./bin/diviner generate --repository 239238 --book src/docs/book/flavor.book --clean, got an appropraite error about a bad repository identifier.

Diff Detail

Repository

Branch

call4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10744
Build 13218: Run Core Tests
Build 13217: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36901.Feb 18 2016, 1:21 AM

epriestley retitled this revision from to Make `bin/diviner generate --repository <repository>` accept identifiers.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added a task: T4245: Make repository URIs slightly prettier.

avivey accepted this revision.Feb 18 2016, 1:23 AM

avivey edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2016, 1:23 AM

Closed by commit rP097bcb397061: Make `bin/diviner generate --repository <repository>` accept identifiers (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 1:23 AM

This revision was automatically updated to reflect the committed changes.

• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM

tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

workflow/

DivinerGenerateWorkflow.php

12 lines

Diff 36901

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...