unbreak exception handling
ClosedPublic
Actions

Authored by avivey on Feb 9 2016, 6:16 PM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10306: undefined method Exception::getClass() on HEAD when git-http-backend is missing

Commits

Restricted Diffusion Commit
rP9519625092a5: unbreak exception handling
rP4c1140a3a789: unbreak exception handling

Summary

fix T10306

Test Plan

¯\_(ツ)_/¯

Diff Detail

Repository

rP Phabricator

Branch

stable

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10595
Build 12996: Run Core Tests
Build 12995: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 36754.Feb 9 2016, 6:16 PM

avivey retitled this revision from to unbreak exception handling.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added reviewers: epriestley, chad.

avivey added a task: T10306: undefined method Exception::getClass() on HEAD when git-http-backend is missing.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 9 2016, 6:16 PM

Herald added a subscriber: Korvin. · View Herald Transcript

less breaking, not more

epriestley accepted this revision.Feb 9 2016, 6:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 9 2016, 6:19 PM

Closed by commit rP4c1140a3a789: unbreak exception handling (authored by avivey, committed by avivey). · Explain WhyFeb 9 2016, 6:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

4 lines

Diff 36754

View Options

src/applications/diffusion/controller/DiffusionServeController.php

unbreak exception handlingClosedPublicActions