unbreak exception handling
ClosedPublic
Actions

Authored by avivey on Feb 9 2016, 6:16 PM.

Tags

None

Referenced Files

	F15462954: D15229.id36756.diff
	Tue, Apr 1, 7:14 PM

	F15452581: D15229.id36755.diff
	Sat, Mar 29, 6:06 AM

	F15451986: D15229.id.diff
	Sat, Mar 29, 12:59 AM

	F15451194: D15229.id36754.diff
	Fri, Mar 28, 8:43 PM

	F15448521: D15229.id36756.diff
	Fri, Mar 28, 5:23 AM

	F15427283: D15229.id36755.diff
	Mar 23 2025, 1:31 PM

	F15424801: D15229.id36756.diff
	Mar 23 2025, 12:21 AM

	F15392871: D15229.id36756.diff
	Mar 15 2025, 6:07 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10306: undefined method Exception::getClass() on HEAD when git-http-backend is missing

Commits

Restricted Diffusion Commit
rP9519625092a5: unbreak exception handling
rP4c1140a3a789: unbreak exception handling

Summary

fix T10306

Test Plan

¯\_(ツ)_/¯

Diff Detail

Repository

rP Phabricator

Branch

stable

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10596
Build 12998: Run Core Tests
Build 12997: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 36754.Feb 9 2016, 6:16 PM

avivey retitled this revision from to unbreak exception handling.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added reviewers: epriestley, chad.

avivey added a task: T10306: undefined method Exception::getClass() on HEAD when git-http-backend is missing.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 9 2016, 6:16 PM

Herald added a subscriber: Korvin. · View Herald Transcript

less breaking, not more

epriestley accepted this revision.Feb 9 2016, 6:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 9 2016, 6:19 PM

Closed by commit rP4c1140a3a789: unbreak exception handling (authored by avivey, committed by avivey). · Explain WhyFeb 9 2016, 6:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

2 lines

Diff 36755

View Options

src/applications/diffusion/controller/DiffusionServeController.php

unbreak exception handlingClosedPublicActions