Page MenuHomePhabricator

Disable "Subprojects" menu item for milestone projects
ClosedPublic

Authored by epriestley on Feb 6 2016, 8:50 PM.
Tags
None
Referenced Files
F13145150: D15200.diff
Fri, May 3, 8:47 AM
Unknown Object (File)
Sat, Apr 27, 6:42 PM
Unknown Object (File)
Thu, Apr 25, 2:37 AM
Unknown Object (File)
Fri, Apr 19, 11:28 PM
Unknown Object (File)
Fri, Apr 19, 5:35 AM
Unknown Object (File)
Fri, Apr 19, 4:25 AM
Unknown Object (File)
Tue, Apr 16, 8:04 PM
Unknown Object (File)
Sun, Apr 7, 11:12 AM
Subscribers
None

Details

Summary

Ref T10010. Milestones can't have subprojects, so this item isn't very useful.

I think there is also an argument for disabling "Members", but that panel is a little less useless and explains the membership rule, so I'm less certain about removing it. I do generally lean toward removing it at some point, though.

Test Plan
  • Viewed a milestone, no "Subprojects" menu item.
  • Viewed a normal project, saw item.
  • Edited both menus, saw consistent UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Disable "Subprojects" menu item for milestone projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2016, 8:52 PM
This revision was automatically updated to reflect the committed changes.