Page MenuHomePhabricator

Disable "Subprojects" menu item for milestone projects
ClosedPublic

Authored by epriestley on Feb 6 2016, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 29, 7:57 PM
Unknown Object (File)
Tue, Nov 29, 7:57 PM
Unknown Object (File)
Tue, Nov 29, 7:57 PM
Unknown Object (File)
Wed, Nov 16, 3:54 PM
Unknown Object (File)
Wed, Nov 16, 3:54 PM
Unknown Object (File)
Wed, Nov 16, 3:54 PM
Unknown Object (File)
Wed, Nov 16, 6:47 AM
Unknown Object (File)
Tue, Nov 15, 9:27 AM
Subscribers
None

Details

Summary

Ref T10010. Milestones can't have subprojects, so this item isn't very useful.

I think there is also an argument for disabling "Members", but that panel is a little less useless and explains the membership rule, so I'm less certain about removing it. I do generally lean toward removing it at some point, though.

Test Plan
  • Viewed a milestone, no "Subprojects" menu item.
  • Viewed a normal project, saw item.
  • Edited both menus, saw consistent UI.

Diff Detail

Repository
rP Phabricator
Branch
pmenu2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10536
Build 12905: Run Core Tests
Build 12904: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Disable "Subprojects" menu item for milestone projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2016, 8:52 PM
This revision was automatically updated to reflect the committed changes.