Paths

Table of Contentst

Allow objects implementing `ArrayAccess` to the passed to `idx`
AbandonedPublic
Actions

Authored by joshuaspence on Jan 28 2016, 11:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 11:44 PM

	Unknown Object (File)
	Fri, Apr 19, 2:24 AM

	Unknown Object (File)
	Fri, Apr 19, 2:24 AM

	Unknown Object (File)
	Thu, Apr 11, 3:43 AM

	Unknown Object (File)
	Wed, Apr 3, 11:06 AM

	Unknown Object (File)
	Mar 16 2024, 7:34 AM

	Unknown Object (File)
	Mar 14 2024, 10:15 AM

	Unknown Object (File)
	Mar 7 2024, 4:52 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

This allows idx to work with CaseInsensitiveArray, for example.

Test Plan

Added a test case.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/utils/utils.php:1194	XHP45	PHP Compatibility
Error	src/utils/utils.php:1194	XHP45	PHP Compatibility

Unit

Tests Passed

Build Status

Buildable 10376
Build 12659: Run Core Tests
Build 12658: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 36537.Jan 28 2016, 11:32 PM

joshuaspence retitled this revision from to Allow objects implementing `ArrayAccess` to the passed to `idx`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2016, 11:32 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley mentioned this in T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.Aug 19 2016, 5:36 PM

Not actively working on this.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

utils/

__tests__/

PhutilUtilsTestCase.php

3 lines

99%

utils.php

9 lines

71%

Diff 36537

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

Allow objects implementing `ArrayAccess` to the passed to `idx`AbandonedPublicActions