Differential D15119

Remove email prefixes from doorkeeper titles
ClosedPublic
Actions

Authored by avivey on Jan 27 2016, 1:30 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10176: JIRA links sorted by count of lines

Commits

Restricted Diffusion Commit
rP8f0d9c329566: Remove email prefixes from doorkeeper titles

Summary

Fixes T10176. The prefix is not useful in the JIRA context, and doubtfully useful in Asana.

Test Plan

Load, make comment on revision, see link in JIRA is pretty.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10347
Build 12615: Run Core Tests
Build 12614: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 36506.Jan 27 2016, 1:30 AM

avivey retitled this revision from to Remove email prefixes from doorkeeper titles.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

avivey added a task: T10176: JIRA links sorted by count of lines.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 27 2016, 1:30 AM

Herald added a subscriber: Korvin. · View Herald Transcript

remove ltrim()

epriestley accepted this revision.Jan 28 2016, 6:17 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 28 2016, 6:17 PM

Closed by commit rP8f0d9c329566: Remove email prefixes from doorkeeper titles (authored by avivey, committed by avivey). · Explain WhyJan 28 2016, 6:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

doorkeeper/

DifferentialDoorkeeperRevisionFeedStoryPublisher.php

7 lines

Diff 36507

View Options

src/applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php

Remove email prefixes from doorkeeper titlesClosedPublicActions