Page MenuHomePhabricator
Differential D15091

Frame workboard empty/create states inside profile menu
ClosedPublic
Actions

Authored by epriestley on Jan 22 2016, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 6:42 PM
Unknown Object (File)
Sat, Dec 21, 9:38 AM
Unknown Object (File)
Wed, Dec 11, 6:48 PM
Unknown Object (File)
Sat, Dec 7, 4:57 PM
Unknown Object (File)
Sat, Dec 7, 5:24 AM
Unknown Object (File)
Sat, Dec 7, 5:24 AM
Unknown Object (File)
Sat, Dec 7, 5:21 AM
Unknown Object (File)
Sat, Dec 7, 5:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T6961: Rendering of workboard columns on card objects could be marginally more efficient
T10054: Define product direction for Project/Profile UIs
Commits
Restricted Diffusion Commit
rPb64d67f47afc: Frame workboard empty/create states inside profile menu
Summary

Ref T10054. Uncreated workboards feel a little awkward right now because you lose the menu. Instead, keep the menu.

I also plan to:

  • add a "[X] Make the workboard the default view for this project." checkbox; and
  • resolve T6961.

...which will touch this workflow, so modernize/straighten it out.

Test Plan

Viewed workboard, no access state, empty state. Created empty board, imported board.

Screen Shot 2016-01-22 at 7.14.54 AM.png (1×1 px, 152 KB)

Diff Detail

Repository
rP Phabricator
Branch
pmenu3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10269
Build 12499: Run Core Tests
Build 12498: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36433.Jan 22 2016, 3:18 PM
epriestley retitled this revision from to Frame workboard empty/create states inside profile menu.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10054: Define product direction for Project/Profile UIs, T6961: Rendering of workboard columns on card objects could be marginally more efficient.
chad accepted this revision.Jan 22 2016, 3:30 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2016, 3:30 PM
Closed by commit rPb64d67f47afc: Frame workboard empty/create states inside profile menu (authored by epriestley, committed by epriestley). · Explain WhyJan 22 2016, 4:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
247 lines

Diff 36433

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
Phabricator · Built by Phacility