Paths

Table of Contentst

Differential D15029

Add a basic remarkup typeahead for users and projects
ClosedPublic
Actions

Authored by epriestley on Jan 15 2016, 1:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 3:52 AM

	Unknown Object (File)
	Sat, Dec 14, 3:33 PM

	Unknown Object (File)
	Fri, Dec 13, 2:45 PM

	Unknown Object (File)
	Fri, Dec 13, 1:05 PM

	Unknown Object (File)
	Thu, Dec 12, 4:21 AM

	Unknown Object (File)
	Mon, Dec 9, 2:45 AM

	Unknown Object (File)
	Thu, Dec 5, 6:59 PM

	Unknown Object (File)
	Wed, Nov 27, 7:25 PM

Subscribers

None

Tokens

"Like" token, awarded by joshuaspence."Mountain of Wealth" token, awarded by avivey."Yellow Medal" token, awarded by chad.

Details

Reviewers

Maniphest Tasks

T3725: Using keyword @ to address users does not autocomplete names

Commits

Restricted Diffusion Commit
rP5d6dd7df7d7a: Add a basic remarkup typeahead for users and projects

Summary

Ref T3725. This probably has 900,000 bugs. This will need updates for subprojects/milestones.

Test Plan

Tested very gently in Safari, Firefox and Chrome.
Reasonable inputs appear to work.
Clicking, escape, tab, return, arrow keys work OK?

Diff Detail

Repository

Branch

auto1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10125
Build 12282: Run Core Tests
Build 12281: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36289.Jan 15 2016, 1:22 PM

epriestley retitled this revision from to Add a basic remarkup typeahead for users and projects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T3725: Using keyword @ to address users does not autocomplete names.

Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 1:22 PM

Screen Shot 2016-01-15 at 5.18.24 AM.png (222×476 px, 15 KB)

Screen Shot 2016-01-15 at 5.18.27 AM.png (238×512 px, 19 KB)

Screen Shot 2016-01-15 at 5.18.29 AM.png (223×414 px, 12 KB)

Screen Shot 2016-01-15 at 5.18.34 AM.png (237×455 px, 22 KB)

Minor style fix.

Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 1:25 PM

Deactivate when the user types @d, then clicks outside the text area.
Deactivate without autocompleting on Shift + Tab.

Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 2:44 PM

If the user types "tab" or "return" to autocomplete but there are no matches, eat it without deactivating.

Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 2:48 PM

Move configuration to PHP.

Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 2:55 PM

When a user types "@", try to guess whether they're trying to type a username or not by examining the text prior to the "@".

Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 3:06 PM

When the user types "@whatever<comma, space or colon>", drop the suffix when querying and retain it when autocompleting so we don't eat spaces/colons/etc.

Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 3:17 PM

whatcouldgowrong4

This revision is now accepted and ready to land.Jan 15 2016, 4:36 PM

(i think this is super awesome btw)

chad awarded a token.Jan 15 2016, 4:36 PM

I think I'm going to cut stable today and then land all this whack junk (this + profile menu).

avivey awarded a token.Jan 15 2016, 4:44 PM

Closed by commit rP5d6dd7df7d7a: Add a basic remarkup typeahead for users and projects (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:11 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence awarded a token.Jan 17 2016, 2:32 AM

joshuaspence mentioned this in T10163: Remarkup Autocomplete Errata.Jan 17 2016, 2:39 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

71 lines

src/

applications/

people/

typeahead/

PhabricatorPeopleDatasource.php

7 lines

project/

typeahead/

PhabricatorProjectDatasource.php

7 lines

typeahead/

storage/

PhabricatorTypeaheadResult.php

11 lines

view/

form/

control/

PhabricatorRemarkupControl.php

17 lines

webroot/

rsrc/

css/

core/

49 lines

4 lines

js/

core/

3 lines

behavior-phabricator-remarkup-assist.js

10 lines

phuix/

PHUIXAutocomplete.js

444 lines

Diff 36293

resources/celerity/map.php

Loading...

src/applications/people/typeahead/PhabricatorPeopleDatasource.php

Loading...

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...

src/applications/typeahead/storage/PhabricatorTypeaheadResult.php

Loading...

src/view/form/control/PhabricatorRemarkupControl.php

Loading...

webroot/rsrc/css/core/remarkup.css

Loading...

webroot/rsrc/css/core/z-index.css

Loading...

webroot/rsrc/js/core/Prefab.js

Loading...

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

Loading...