Ref T3725. This probably has 900,000 bugs. This will need updates for subprojects/milestones.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T3725: Using keyword @ to address users does not autocomplete names
- Commits
- Restricted Diffusion Commit
rP5d6dd7df7d7a: Add a basic remarkup typeahead for users and projects
- Tested very gently in Safari, Firefox and Chrome.
- Reasonable inputs appear to work.
- Clicking, escape, tab, return, arrow keys work OK?
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- auto1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10124 Build 12280: Run Core Tests Build 12279: arc lint + arc unit
Event Timeline
Comment Actions
- Deactivate when the user types @d, then clicks outside the text area.
- Deactivate without autocompleting on Shift + Tab.
Comment Actions
- If the user types "tab" or "return" to autocomplete but there are no matches, eat it without deactivating.
Comment Actions
- When a user types "@", try to guess whether they're trying to type a username or not by examining the text prior to the "@".
Comment Actions
- When the user types "@whatever<comma, space or colon>", drop the suffix when querying and retain it when autocompleting so we don't eat spaces/colons/etc.
Comment Actions
I think I'm going to cut stable today and then land all this whack junk (this + profile menu).